Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 7th No.28】为 paddle.clip 进行功能增强 #69193

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

a162837
Copy link

@a162837 a162837 commented Nov 5, 2024

PR Category

Inference

PR Types

Others

Description

【Hackathon 7th No.28】为 paddle.clip 进行功能增强

PaddlePaddle/docs#6924

Copy link

paddle-bot bot commented Nov 5, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@a162837
Copy link
Author

a162837 commented Nov 6, 2024

已经全都好了,麻烦review一下 @luotao1 @zhwesky2010

@zhwesky2010
Copy link
Contributor

这个还是不能在python层写,需改造已有的kernel

@a162837
Copy link
Author

a162837 commented Nov 7, 2024

这个还是不能在python层写,需改造已有的kernel

改造已有kernel的话,是除了cpu,gpu的其他计算芯片也都实现吗?然后也需要实现对应的二阶推导对吗

@a162837
Copy link
Author

a162837 commented Nov 7, 2024

改造已有的,我也想过,就是同样是expand结合where实现,传入scale的时候使用full_like转为Tensor。这样是可以的吧

@a162837
Copy link
Author

a162837 commented Nov 7, 2024

我参考paddle.where的做法实现吧,是可以的吧? @zhwesky2010

@a162837
Copy link
Author

a162837 commented Nov 10, 2024

他一直不变的?

@a162837
Copy link
Author

a162837 commented Nov 10, 2024

我觉得这个难度是不是标错了?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants